On Mon, Nov 27, 2017 at 10:46 AM, Dan Carpenter
[off-list ref] wrote:

On Sat, Nov 25, 2017 at 01:26:35PM -0500, Jeremy Lacomis wrote:

quoted

This patch to ddk750_sii164.h fixes line length warnings found by the
checkpatch.pl script and reformats comments uniformly.

Signed-off-by: Jeremy Lacomis <redacted>
---
 drivers/staging/sm750fb/ddk750_sii164.h | 57 +++++++++++++--------------------
 1 file changed, 22 insertions(+), 35 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index 2e9a88cd6af3..393a3c5be3ae 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h

@@ -4,15 +4,20 @@

 #define USE_DVICHIP

-/* Hot Plug detection mode structure */
+/*
+ * Hot Plug detection mode structure:
+ *      Disable Hot Plug output bit (always high).
+ *      Use Monitor Detect Interrupt bit.
+ *      Use Receiver Sense detect bit.
+ *      Use Hot Plug detect bit.
+ */
 enum sii164_hot_plug_mode {
-     SII164_HOTPLUG_DISABLE = 0,         /* Disable Hot Plug output bit (always high). */
-     SII164_HOTPLUG_USE_MDI,             /* Use Monitor Detect Interrupt bit. */
-     SII164_HOTPLUG_USE_RSEN,            /* Use Receiver Sense detect bit. */
-     SII164_HOTPLUG_USE_HTPLG            /* Use Hot Plug detect bit. */
+     SII164_HOTPLUG_DISABLE = 0,
+     SII164_HOTPLUG_USE_MDI,
+     SII164_HOTPLUG_USE_RSEN,
+     SII164_HOTPLUG_USE_HTPLG
 };

I feel like this makes it less readable.  The original was better.

And more error prone.

NAKed-by: Geert Uytterhoeven [off-list ref]

Please use common sense when following checkpatch.pl's advise.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds