video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init()

Started by SF Markus Elfring on Nov 27, 2017 · 3 messages from 3 authors · Last reply Mar 28, 2018

Subsystems (3)

Maintainers (3)

STALE3151d

open the first message on its own page

Message details and related content
From: Markus Elfring <redacted>
Date: Mon, 27 Nov 2017 09:56:09 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/video/fbdev/fsl-diu-fb.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
index 25abbcf38913..1bfd13cbd4e3 100644
--- a/drivers/video/fbdev/fsl-diu-fb.c
+++ b/drivers/video/fbdev/fsl-diu-fb.c
@@ -1960,12 +1960,8 @@ static int __init fsl_diu_init(void)
 
 	of_node_put(np);
 	coherence_data = vmalloc(coherence_data_size);
-	if (!coherence_data) {
-		pr_err("fsl-diu-fb: could not allocate coherence data "
-		       "(size=%zu)\n", coherence_data_size);
+	if (!coherence_data)
 		return -ENOMEM;
-	}
-
 #endif
 
 	ret = platform_driver_register(&fsl_diu_driver);
-- 
2.15.0
Message details and related content
On 11/27/17 3:00 AM, SF Markus Elfring wrote:
From: Markus Elfring<redacted>
Date: Mon, 27 Nov 2017 09:56:09 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring<redacted>
Acked-by: Timur Tabi <redacted>
Message details and related content
On Monday, November 27, 2017 11:31:10 AM Timur Tabi wrote:
On 11/27/17 3:00 AM, SF Markus Elfring wrote:
quoted
From: Markus Elfring<redacted>
Date: Mon, 27 Nov 2017 09:56:09 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring<redacted>
Acked-by: Timur Tabi <redacted>
Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help