Thread (2 messages) flat view 2 messages, 2 authors, 2017-11-13

Re: [PATCH] fbcon: Initialize ops->info early

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2017-11-13 17:20:19
Also in: dri-devel, lkml

On Monday, November 13, 2017 10:45:46 AM Thierry Reding wrote:
From: Thierry Reding <redacted>

During console takeover, which happens for all DRM/KMS setups using the
fbdev helpers, fbcon_startup() is called before fbcon_init() and as a
result con2fb_acquire_newinfo() will not be called (info->fbcon_par was
set to non-NULL in fbcon_startup()) to assign ops->info.

This causes the cursor_timer_handler() to unreference a NULL pointer.

Avoid this by unconditionally assigning ops->info during fbcon_startup()
so that it will be available early, but keep the additional assignment
in con2fb_acquire_newinfo() to support console remapping at runtime.

Cc: Kees Cook <redacted>
Signed-off-by: Thierry Reding <redacted>
Patch queued for 4.15, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help