Re: [PATCH v3 1/7] fbcon: Add fbcon_rotate_hint to struct fb_info

Hi,

On 23-10-17 14:43, Sebastian Reichel wrote:

Hi Hans,

On Mon, Oct 23, 2017 at 09:14:19AM +0200, Hans de Goede wrote:

quoted

On some hardware the LCD panel is not mounted upright in the casing,
but upside-down or rotated 90 degrees. In this case we want the console
to automatically be rotated to compensate.

The fbdev-driver may know about the need to rotate. Add a new
fbcon_rotate_hint field to struct fb_info, which gets initialized to -1.
If the fbdev-driver knows that some sort of rotation is necessary then
it can set this field to a FB_ROTATE_* value to tell the fbcon console
driver to rotate the console.

Signed-off-by: Hans de Goede <redacted>
---

Thanks for your work. I will give it a try with Droid 4 and N950
once I find some time :)

Ah, I did not even realize that this work would be useful for those
too, but yes that makes sense.

[...]

quoted

+	p->con_rotate = initial_rotation;
+	if (p->con_rotate = -1)
+		p->con_rotate = info->fbcon_rotate_hint;
+	if (p->con_rotate = -1)
  		p->con_rotate = fbcon_platform_get_rotate(info);

[...]

quoted

+	p->con_rotate = initial_rotation;
+	if (p->con_rotate = -1)
+		p->con_rotate = info->fbcon_rotate_hint;
+	if (p->con_rotate = -1)
  		p->con_rotate = fbcon_platform_get_rotate(info);
+

maybe add a little helper function to reduce code duplication?

Maybe, I took a look and there already is a fbcon_set_rotation()
helper which does something completely different, so it might
be best to just keep this as is to avoid confusion between
2 similar named functions.

Regards,

Hans