Thread (21 messages) 21 messages, 8 authors, 2017-10-12

Lifecycle

  1. Posted Allen Pais <allen.lkml@gmail.com>

[PATCH 07/10] driver:megaraid: return -ENOMEM on allocation failure.

From: Allen Pais <hidden>
Date: 2017-09-13 07:35:02
Also in: dri-devel, linux-btrfs, linux-crypto, linux-scsi, lkml, netdev, nouveau, target-devel
Subsystem: megaraid scsi/sas drivers, scsi subsystem, the rest · Maintainers: Kashyap Desai, Sumit Saxena, Shivasharan S, Chandrakanth patil, "James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds

Signed-off-by: Allen Pais <redacted>
---
 drivers/scsi/megaraid/megaraid_mbox.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c
index ec3c438..b09a0a6 100644
--- a/drivers/scsi/megaraid/megaraid_mbox.c
+++ b/drivers/scsi/megaraid/megaraid_mbox.c
@@ -724,8 +724,8 @@ megaraid_init_mbox(adapter_t *adapter)
 	 * controllers
 	 */
 	raid_dev = kzalloc(sizeof(mraid_device_t), GFP_KERNEL);
-	if (raid_dev = NULL) return -1;
-
+	if (!raid_dev)
+		return -ENOMEM;
 
 	/*
 	 * Attach the adapter soft state to raid device soft state
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help