Re: [PATCH] drivers: video: Fix 80 character limit and remove unnecessary space

On Wed, 2017-08-23 at 18:12 +0200, Bartlomiej Zolnierkiewicz wrote:

Hi,

Please use a more descriptive patch subject, i.e.
"fbdev: vgastate: fix checkpatch.pl reported warnings".

Please also cc: fbdev mailing list (linux-fbdev@vger.kernel.org
on fbdev patches).

On Monday, August 21, 2017 07:33:51 PM Himanshu Jha wrote:

quoted

Fixes the following checkpatch warnings:
WARNING: line over 80 characters
WARNING: space prohibited between function name and open parenthesis '('
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

[]

quoted

diff --git a/drivers/video/vgastate.c b/drivers/video/vgastate.c

[]

quoted

@@ -31,8 +31,9 @@ struct regstate {
 	__u8 misc;
 };
 
-static inline unsigned char vga_rcrtcs(void __iomem *regbase, unsigned short iobase,
-				       unsigned char reg)
+static inline unsigned char vga_rcrtcs(void __iomem *regbase,
+						unsigned short iobase,
+							unsigned char reg)

This is not an improvement and doesn't conform to the kernel CodingStyle.

It should be:

static inline unsigned char vga_rcrtcs(void __iomem *regbase,
				       unsigned short iobase,
				       unsigned char reg)

quoted

 {
 	vga_w(regbase, iobase + 0x4, reg);
 	return vga_r(regbase, iobase + 0x5);

Better to remove the inline and let the compiler decide too.

Perhaps:

static unsigned char vga_rcrtcs(void __iomem *regbase, unsigned short iobase,
				unsigned char reg)