Started by Bhumika Goyal on Aug 10, 2017 · 5 messages from 2 authors · Last reply Aug 21, 2017
2 patches, 2 files
+2 −2
open the first message on its own page
B Bhumika Goyal #
Make these const. Bhumika Goyal (2): fbdev: matrox: make fb_ops const fbdev: i810: make fb_ops const drivers/video/fbdev/i810/i810_main.c | 2 +- drivers/video/fbdev/matrox/matroxfb_base.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 1.9.1
B Bhumika Goyal replied to Bhumika Goyal #
Make fb_ops const as it is only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <redacted>
---
drivers/video/fbdev/matrox/matroxfb_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c
index 00ea4e4..49ef48d 100644
--- a/drivers/video/fbdev/matrox/matroxfb_base.c
+++ b/drivers/video/fbdev/matrox/matroxfb_base.c@@ -1198,7 +1198,7 @@ static int matroxfb_blank(int blank, struct fb_info *info) return 0; } -static struct fb_ops matroxfb_ops = { +static const struct fb_ops matroxfb_ops = { .owner = THIS_MODULE, .fb_open = matroxfb_open, .fb_release = matroxfb_release,
--
1.9.1
B Bhumika Goyal replied to Bhumika Goyal #
Make the structure const as it is only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <redacted>
---
drivers/video/fbdev/i810/i810_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
index f0a758a..d18f7b3 100644
--- a/drivers/video/fbdev/i810/i810_main.c
+++ b/drivers/video/fbdev/i810/i810_main.c@@ -1542,7 +1542,7 @@ static int i810fb_cursor(struct fb_info *info, struct fb_cursor *cursor) return 0; } -static struct fb_ops i810fb_ops = { +static const struct fb_ops i810fb_ops = { .owner = THIS_MODULE, .fb_open = i810fb_open, .fb_release = i810fb_release,
--
1.9.1
B Bartlomiej Zolnierkiewicz replied to Bhumika Goyal #
On Thursday, August 10, 2017 02:46:44 PM Bhumika Goyal wrote:
Make fb_ops const as it is only used during a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal <redacted>
Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
B Bartlomiej Zolnierkiewicz replied to Bhumika Goyal #
On Thursday, August 10, 2017 02:46:45 PM Bhumika Goyal wrote:
Make the structure const as it is only used during a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal <redacted>
Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics