Thread (2 messages) flat view 2 messages, 2 authors, 2017-08-01
STALE3344d

[PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning

From: Lynn Lei <hidden>
Date: 2017-07-04 15:24:47
Also in: lkml
Subsystem: framebuffer layer, silicon motion sm712 frame buffer driver, the rest · Maintainers: Helge Deller, Sudip Mukherjee, Teddy Wang, Sudip Mukherjee, Linus Torvalds

Fixed a constant-left comparison warning issue check by
scripts/checkpatch.pl:
  WARNING: Comparisons should place the constant on the right side of the test

Signed-off-by: Lynn Lei <redacted>
---
 drivers/video/fbdev/sm712fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c
index 172e94146878..502d0de2feec 100644
--- a/drivers/video/fbdev/sm712fb.c
+++ b/drivers/video/fbdev/sm712fb.c
@@ -1478,7 +1478,7 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
 	}
 
 	/* can support 32 bpp */
-	if (15 = sfb->fb->var.bits_per_pixel)
+	if (sfb->fb->var.bits_per_pixel = 15)
 		sfb->fb->var.bits_per_pixel = 16;
 
 	sfb->fb->var.xres_virtual = sfb->fb->var.xres;
-- 
2.13.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help