Re: [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one statement
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Date: 2017-04-28 11:59:19
Also in:
lkml
On Tue, Apr 25, 2017 at 03:53:02PM +0000, Lynn Lei wrote:
Combine two separate set GPIO(30 & 31) operations into one statement.
Why?
quoted hunk
Signed-off-by: Lynn Lei <redacted> --- drivers/staging/sm750fb/ddk750_hwi2c.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c index 68716ef7cb06..ddb7a6dc265a 100644 --- a/drivers/staging/sm750fb/ddk750_hwi2c.c +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c@@ -49,8 +49,7 @@ void sm750_hw_i2c_close(void) /* Set GPIO 30 & 31 back as GPIO pins */ value = peek32(GPIO_MUX); - value &= ~GPIO_MUX_30; - value &= ~GPIO_MUX_31; + value &= ~(GPIO_MUX_30 | GPIO_MUX_31);
Why does this matter? thanks, greg k-h