[PATCH] video/logo: tidyup fb_logo_late_init initcall timing

Subsystems: framebuffer layer, the rest

STALE3473d REVIEWED: 6 (6M)

1 review trailer.

2 messages, 2 authors, 2017-03-20 · open the first message on its own page

[PATCH] video/logo: tidyup fb_logo_late_init initcall timing

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: 2017-03-08 10:22:20

From: Takeshi Kihara <redacted>

Some video driver might returns -EPROBE_DEFER when probe timing,
but logo init function doesn't care it.
Thus, such kernel can't have logo when boot time.

This patch solves this issue by exchanging current
late_initcall to late_initcall_sync

Signed-off-by: Takeshi Kihara <redacted>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/video/logo/logo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/logo/logo.c b/drivers/video/logo/logo.c
index b6bc4a0..4d50bfd 100644
--- a/drivers/video/logo/logo.c
+++ b/drivers/video/logo/logo.c
@@ -34,7 +34,7 @@ static int __init fb_logo_late_init(void)
 	return 0;
 }
 
-late_initcall(fb_logo_late_init);
+late_initcall_sync(fb_logo_late_init);
 
 /* logo's are marked __initdata. Use __ref to tell
  * modpost that it is intended that this function uses data
-- 
1.9.1

Re: [PATCH] video/logo: tidyup fb_logo_late_init initcall timing

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2017-03-20 17:29:32

On Wednesday, March 08, 2017 10:14:33 AM Kuninori Morimoto wrote:
From: Takeshi Kihara <redacted>

Some video driver might returns -EPROBE_DEFER when probe timing,
but logo init function doesn't care it.
Thus, such kernel can't have logo when boot time.

This patch solves this issue by exchanging current
late_initcall to late_initcall_sync

Signed-off-by: Takeshi Kihara <redacted>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch queued for 4.12, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help