Re: [PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2017-03-06 19:36:51
Also in:
lkml
Hi Arushi, On Sun, Mar 5, 2017 at 12:24 PM, Arushi Singhal [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal <redacted> --- drivers/staging/sm750fb/ddk750_display.h | 1 + drivers/staging/sm750fb/ddk750_mode.h | 2 ++ drivers/staging/sm750fb/ddk750_power.h | 1 + drivers/staging/sm750fb/sm750_cursor.c | 3 +++ 4 files changed, 7 insertions(+)diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h index e2a3f84ca4c5..8bf22e4f0d8b 100644 --- a/drivers/staging/sm750fb/ddk750_display.h +++ b/drivers/staging/sm750fb/ddk750_display.h@@ -100,6 +100,7 @@ typedef enum _disp_output_t { do_CRT_PRI = CRT_2_PRI | PRI_TP_ON | DPMS_ON | DAC_ON, do_CRT_SEC = CRT_2_SEC | SEC_TP_ON | DPMS_ON | DAC_ON, } + disp_output_t;
That's a false positive. Actually "disp_output_t" should be on the previous line, after the closing curly brace, as variable types and names must not be split.
quoted hunk ↗ jump to hunk
--- a/drivers/staging/sm750fb/ddk750_mode.h +++ b/drivers/staging/sm750fb/ddk750_mode.h@@ -7,6 +7,7 @@ typedef enum _spolarity_t { POS = 0, /* positive */ NEG, /* negative */ } + spolarity_t; typedef struct _mode_parameter_t {@@ -32,6 +33,7 @@ typedef struct _mode_parameter_t { /* Clock Phase. This clock phase only applies to Panel. */ spolarity_t clock_phase_polarity; } + mode_parameter_t;
Likewise.
quoted hunk ↗ jump to hunk
--- a/drivers/staging/sm750fb/ddk750_power.h +++ b/drivers/staging/sm750fb/ddk750_power.h@@ -7,6 +7,7 @@ typedef enum _DPMS_t { crtDPMS_SUSPEND = 0x2, crtDPMS_OFF = 0x3, } + DPMS_t;
Likewise.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds