Re: [PATCH] staging: sm750fb: Enclose macro arguments in parentheses
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2017-02-07 19:48:37
On Tue, Feb 07, 2017 at 11:11:22AM -0800, Matthieu Simon wrote:
quoted hunk ↗ jump to hunk
checkpatch noticed possible precedence issues resulting in the definition of PEEK32 and POKE32. So, these arguments should be enclosed in parentheses. Signed-off-by: Matthieu Simon <redacted> --- drivers/staging/sm750fb/ddk750_chip.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h index e63b8b293816..a5f910344373 100644 --- a/drivers/staging/sm750fb/ddk750_chip.h +++ b/drivers/staging/sm750fb/ddk750_chip.h@@ -10,8 +10,8 @@ #include <linux/uaccess.h> /* software control endianness */ -#define PEEK32(addr) readl(addr + mmio750) -#define POKE32(addr, data) writel(data, addr + mmio750) +#define PEEK32(addr) readl((addr) + mmio750) +#define POKE32(addr, data) writel((data), (addr) + mmio750)
Those are funny macros, how about just making them an inline function so that we get the correct type-checking and better documentation as to what is going on with them? thanks, greg k-h