Re: [PATCH v2 7/7] uapi: export all headers under uapi directories

From
Nicolas Dichtel <hidden>
Date
2017-01-12 16:32:23
Also in
alsa-devel, dri-devel, linux-alpha, linux-arch, linux-arm-kernel, linux-kbuild, linux-media, linux-mips, linux-mmc, linux-nfs, linux-raid, linux-rdma, linux-s390, linux-sh, linux-spi, linuxppc-dev, lkml, netdev, netfilter-devel, sparclinux
Reply to
Jan Engelhardt, 2017-01-12
Le 12/01/2017 à 17:28, Jan Engelhardt a écrit :
On Thursday 2017-01-12 16:52, Nicolas Dichtel wrote:
quoted
Le 09/01/2017 à 13:56, Christoph Hellwig a écrit :
quoted
On Fri, Jan 06, 2017 at 10:43:59AM +0100, Nicolas Dichtel wrote:
quoted
Regularly, when a new header is created in include/uapi/, the developer
forgets to add it in the corresponding Kbuild file. This error is usually
detected after the release is out.

In fact, all headers under uapi directories should be exported, thus it's
useless to have an exhaustive list.

After this patch, the following files, which were not exported, are now
exported (with make headers_install_all):
... snip ...
quoted
linux/genwqe/.install
linux/genwqe/..install.cmd
linux/cifs/.install
linux/cifs/..install.cmd
I'm pretty sure these should not be exported!
Those files are created in every directory:
$ find usr/include/ -name '\.\.install.cmd' | wc -l
71
That still does not mean they should be exported.

Anything but headers (and directories as a skeleton structure) is maximally suspicious.
What I was trying to say is that I export those directories like other are.
Removing those files is not related to that series.


Regards,
Nicolas
Thread (41 messages) 41 messages, 14 authors, last reply 2017-01-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help