Re: [PATCH v4 1/6] Add Advantech iManager MFD core driver
From: Lee Jones <hidden>
Date: 2016-11-03 08:39:12
Also in:
linux-gpio, linux-hwmon, linux-i2c, linux-watchdog, lkml
On Wed, 02 Nov 2016, Richard Vidal-Dorsch wrote:
This patch adds Advantech iManager Embedded Controller MFD core driver. This mfd core dirver provides an interface for GPIO, I2C, HWmon, Watchdog, and Backlight/Brightness control. Signed-off-by: Richard Vidal-Dorsch <redacted> --- drivers/mfd/Kconfig | 18 + drivers/mfd/Makefile | 1 + drivers/mfd/imanager-core.c | 941 ++++++++++++++++++++++++++++++++++++++++ include/linux/mfd/imanager-ec.h | 228 ++++++++++ include/linux/mfd/imanager.h | 221 ++++++++++ 5 files changed, 1409 insertions(+) create mode 100644 drivers/mfd/imanager-core.c create mode 100644 include/linux/mfd/imanager-ec.h create mode 100644 include/linux/mfd/imanager.h
After a brief review, it is my belief that this looks like a platform driver, which should live in drivers/platform/. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog