Thread (6 messages) flat view 6 messages, 2 authors, 2016-10-04

Re: [PATCH -resend 4/6] mdacon: enable COMPILE_TEST build

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2016-10-03 09:35:34
Also in: lkml

On Mon, Oct 3, 2016 at 11:07 AM, Jiri Slaby [off-list ref] wrote:
quoted hunk ↗ jump to hunk
It can be built even on systems without ISA. So enable compile testing
by specifying ISA || COMPILE_TEST.

Signed-off-by: Jiri Slaby <redacted>
Cc: Tomi Valkeinen <redacted>
Cc: <redacted>
---
 drivers/video/console/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
index 38da6e299149..7e9e8be24134 100644
--- a/drivers/video/console/Kconfig
+++ b/drivers/video/console/Kconfig
@@ -48,7 +48,7 @@ config VGACON_SOFT_SCROLLBACK_SIZE
         screenfuls of scrollback buffer

 config MDA_CONSOLE
-       depends on !M68K && !PARISC && ISA
+       depends on !M68K && !PARISC && (ISA || COMPILE_TEST)
My first thought was

    depends on (!M68K && !PARISC && ISA) || COMPILE_TEST

but arch/m68k/include/asm/vga.h doesn't define VGA_MAP_MEM().
Adding #include <asm-generic/vga.h> at the end of arch/m68k/include/asm/vga.h
fixes that.

Do we want that?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help