staging: sm750fb: Fix printk() style warning

Started by Edward Lipinsky on Oct 2, 2016 · 7 messages from 3 authors · Last reply Oct 14, 2016

Subsystems (3)

Maintainers (5)

Show 1 more
STALE3688d

open the first message on its own page

Message details and related content
This patch fixes the checkpatch.pl warning:

WARNING: printk() should include KERN_ facility level

Signed-off-by: Edward Lipinsky <redacted>
---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..e72a29c 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId = 0xfe)
-		printk("found sm750le\n");
+		pr_info("found sm750le\n");
 }
 
 
-- 
2.7.4
Message details and related content
On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote:
quoted hunk
This patch fixes the checkpatch.pl warning:

WARNING: printk() should include KERN_ facility level

Signed-off-by: Edward Lipinsky <redacted>
---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..e72a29c 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId = 0xfe)
-		printk("found sm750le\n");
+		pr_info("found sm750le\n");
Why can't you use dev_info() here?

thanks,

greg k-h
Message details and related content
On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote:
On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote:
quoted
This patch fixes the checkpatch.pl warning:

WARNING: printk() should include KERN_ facility level

Signed-off-by: Edward Lipinsky <redacted>
---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..e72a29c 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId = 0xfe)
-		printk("found sm750le\n");
+		pr_info("found sm750le\n");
Why can't you use dev_info() here?

thanks,

greg k-h
It should work, but I'm not sure what should change in the header files to
do it--esp. to make the dev parameter available in ddk750_help.c.  (Only
sm750.c uses dev_ style logging now, the rest of the driver still uses pr_*.)

Thanks,

Ed Lipinsky
Message details and related content
On Thu, Oct 06, 2016 at 09:27:36PM -0700, Edward Lipinsky wrote:
On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote:
quoted
On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote:
quoted
This patch fixes the checkpatch.pl warning:

WARNING: printk() should include KERN_ facility level

Signed-off-by: Edward Lipinsky <redacted>
---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..e72a29c 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId = 0xfe)
-		printk("found sm750le\n");
+		pr_info("found sm750le\n");
Why can't you use dev_info() here?

thanks,

greg k-h
It should work, but I'm not sure what should change in the header files to
do it--esp. to make the dev parameter available in ddk750_help.c.  (Only
sm750.c uses dev_ style logging now, the rest of the driver still uses pr_*.)
This printk can be moved to lynxfb_pci_probe, and then it should be no
problem to use dev_info. Just make sure to update the commit message
appropriately. 
 
Thanks,

Ed Lipinsky
--
Sincerely yours,
Mike.
Message details and related content
On Fri, Oct 07, 2016 at 11:12:04AM +0200, Mike Rapoport wrote:
On Thu, Oct 06, 2016 at 09:27:36PM -0700, Edward Lipinsky wrote:
quoted
On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote:
quoted
On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote:
quoted
This patch fixes the checkpatch.pl warning:

WARNING: printk() should include KERN_ facility level

Signed-off-by: Edward Lipinsky <redacted>
---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..e72a29c 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId = 0xfe)
-		printk("found sm750le\n");
+		pr_info("found sm750le\n");
Why can't you use dev_info() here?

thanks,

greg k-h
It should work, but I'm not sure what should change in the header files to
do it--esp. to make the dev parameter available in ddk750_help.c.  (Only
sm750.c uses dev_ style logging now, the rest of the driver still uses pr_*.)
This printk can be moved to lynxfb_pci_probe, and then it should be no
problem to use dev_info. Just make sure to update the commit message
appropriately. 
 
quoted
Thanks,

Ed Lipinsky

5 more quoted lines

Thanks, that makes sense.  I tried deleting the if statement and printk()
from ddk750_help.c, and adding the following in lynxfb_pci_probe() after
calling hw_sm750_map() and checking for errors:

if (sm750_dev->revid = 0xfe)
	dev_info(&pdev->dev, "found sm750le\n");

The driver compiles, loads and unloads ok with this code.

Does this look correct?

Regards,
Ed L.
Message details and related content
On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote:
Thanks, that makes sense.  I tried deleting the if statement and printk()
from ddk750_help.c, and adding the following in lynxfb_pci_probe() after
calling hw_sm750_map() and checking for errors:

if (sm750_dev->revid = 0xfe)
	dev_info(&pdev->dev, "found sm750le\n");

The driver compiles, loads and unloads ok with this code.

Does this look correct?
Yep, seems just right.
 
Regards,
Ed L.
Message details and related content
On Thu, Oct 13, 2016 at 05:39:22PM +0300, Mike Rapoport wrote:
On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote:
quoted
Thanks, that makes sense.  I tried deleting the if statement and printk()
from ddk750_help.c, and adding the following in lynxfb_pci_probe() after
calling hw_sm750_map() and checking for errors:

if (sm750_dev->revid = 0xfe)
	dev_info(&pdev->dev, "found sm750le\n");

The driver compiles, loads and unloads ok with this code.

Does this look correct?
Yep, seems just right.
 
quoted
Regards,
Ed L.
Good, thanks.  I will submit an updated patch.

Regards,
Ed L.
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help