Re: [PATCH] staging: sm750fb: Fix lock context error

From
<hidden>
Date
2016-10-24 12:12:40
Reply to
Alex Briskin, 2016-10-23
On Monday, 24 October 2016 13:41:39 IDT Dan Carpenter wrote:
evaluation
Hi Dan,
Thanks you for your feedback, it kind of felt like workaround.
However, it seems to me like bad design decision took place where locking/
unlocking is dependent on unprotected variable.
From what I could understand from the driver source code the fb_count value 
shouldn't change while in those functions, so the code is safe "as is" and my 
change should only assist with readability. 
So the patch fails to improve readability it is unnecessary.

Best regards,
Alex
Thread (3 messages) 3 messages, 2 authors, last reply 2016-10-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help