Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters... | linux-fbdev

[PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags · Lorenzo Stoakes <hidden> · 2016-10-13
[PATCH 01/10] mm: remove write/force parameters from __get_user_pages_locked() · Lorenzo Stoakes <hidden> · 2016-10-13
Re: [PATCH 01/10] mm: remove write/force parameters from __get_user_pages_locked() · Jan Kara <jack@suse.cz> · 2016-10-18
[PATCH 02/10] mm: remove write/force parameters from __get_user_pages_unlocked() · Lorenzo Stoakes <hidden> · 2016-10-13
Re: [PATCH 02/10] mm: remove write/force parameters from __get_user_pages_unlocked() · Paolo Bonzini <pbonzini@redhat.com> · 2016-10-13
Re: [PATCH 02/10] mm: remove write/force parameters from __get_user_pages_unlocked() · Jan Kara <jack@suse.cz> · 2016-10-18
[PATCH 03/10] mm: replace get_user_pages_unlocked() write/force parameters with gup_flags · Lorenzo Stoakes <hidden> · 2016-10-13
Re: [PATCH 03/10] mm: replace get_user_pages_unlocked() write/force parameters with gup_flags · Jan Kara <jack@suse.cz> · 2016-10-18
[PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags · Lorenzo Stoakes <hidden> · 2016-10-13
Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags · Jan Kara <jack@suse.cz> · 2016-10-18
Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags · Lorenzo Stoakes <hidden> · 2016-10-18
Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags · Jan Kara <jack@suse.cz> · 2016-10-19
Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags · Jan Kara <jack@suse.cz> · 2016-10-19
[PATCH 05/10] mm: replace get_vaddr_frames() write/force parameters with gup_flags · Lorenzo Stoakes <hidden> · 2016-10-13
Re: [PATCH 05/10] mm: replace get_vaddr_frames() write/force parameters with gup_flags · Jan Kara <jack@suse.cz> · 2016-10-19
[PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags · Lorenzo Stoakes <hidden> · 2016-10-13
Re: [PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags · Jesper Nilsson <jesper.nilsson@axis.com> · 2016-10-17
Re: [PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags · Jan Kara <jack@suse.cz> · 2016-10-19
[PATCH 07/10] mm: replace get_user_pages_remote() write/force parameters with gup_flags · Lorenzo Stoakes <hidden> · 2016-10-13
Re: [PATCH 07/10] mm: replace get_user_pages_remote() write/force parameters with gup_flags · Jan Kara <jack@suse.cz> · 2016-10-19
[PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags · Lorenzo Stoakes <hidden> · 2016-10-13
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags · Jan Kara <jack@suse.cz> · 2016-10-19
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags · Michal Hocko <mhocko@kernel.org> · 2016-10-19
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags · Lorenzo Stoakes <hidden> · 2016-10-19
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags · Michal Hocko <mhocko@kernel.org> · 2016-10-19
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags · Lorenzo Stoakes <hidden> · 2016-10-19
Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags · Michal Hocko <mhocko@kernel.org> · 2016-10-19
[PATCH 09/10] mm: replace access_remote_vm() write parameter with gup_flags · Lorenzo Stoakes <hidden> · 2016-10-13
[PATCH 10/10] mm: replace access_process_vm() write parameter with gup_flags · Lorenzo Stoakes <hidden> · 2016-10-13
Re: [PATCH 10/10] mm: replace access_process_vm() write parameter with gup_flags · Jesper Nilsson <jesper.nilsson@axis.com> · 2016-10-17
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags · Christian König <christian.koenig@amd.com> · 2016-10-13
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags · Michal Hocko <mhocko@kernel.org> · 2016-10-18
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags · Lorenzo Stoakes <hidden> · 2016-10-19
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags · Michal Hocko <mhocko@kernel.org> · 2016-10-19
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags · Dave Hansen <dave.hansen@linux.intel.com> · 2016-10-19
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags · Michal Hocko <mhocko@kernel.org> · 2016-10-19
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags · Dave Hansen <dave.hansen@linux.intel.com> · 2016-10-19
Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags · Michal Hocko <mhocko@kernel.org> · 2016-10-20

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

From: Jan Kara <jack@suse.cz>
Date: 2016-10-19 07:33:36
Also in: ceph-devel, dri-devel, intel-gfx, kvm, linux-alpha, linux-arm-kernel, linux-fsdevel, linux-media, linux-mips, linux-mm, linux-rdma, linux-s390, linux-samsung-soc, linux-scsi, linux-sh, linuxppc-dev, lkml, netdev, sparclinux

On Thu 13-10-16 01:20:14, Lorenzo Stoakes wrote:

This patch removes the write and force parameters from get_user_pages_locked()
and replaces them with a gup_flags parameter to make the use of FOLL_FORCE
explicit in callers as use of this flag can result in surprising behaviour (and
hence bugs) within the mm subsystem.

Signed-off-by: Lorenzo Stoakes <redacted>

After our discussion the patch looks good to me. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help