Re: [PATCH] simplefb: Disable and release clocks and regulators in destroy callback

From
Geert Uytterhoeven <geert@linux-m68k.org>
Date
2016-09-07 11:12:23
Also in
linux-arm-kernel, lkml
Reply to
Chen-Yu Tsai, 2016-09-07
On Wed, Sep 7, 2016 at 11:09 AM, Chen-Yu Tsai [off-list ref] wrote:
simplefb gets unregister when a proper framebuffer driver comes in and
kicks it out. However the claimed clocks and regulators stay enabled
as they are only released in the platform device remove function, which
in theory would never get called.

Move the clock/regulator cleanup into the framebuffer destroy callback,
which gets called as part of the framebuffer unregister process.
Is this called before or after the new proper framebuffer driver kicks in?
If before, it may cause glitches.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Thread (6 messages) 6 messages, 4 authors, last reply 2016-09-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help