Re: [PATCH] video: mxsfb: get supply regulator optionally

From
Tomi Valkeinen <hidden>
Date
2016-09-06 08:21:53
Also in
linux-devicetree, lkml
Reply to
Stefan Agner, 2016-09-04
Hi,

On 04/09/16 07:26, Stefan Agner wrote:
The lcd-supply is meant to be optional, there are several device-
trees not specifying it and the code handles error values silently.
Therefor, avoid creating a dummy regulator (and the associated
warning) by using devm_regulator_get_optional.

While at it, document that fact also in the device-tree bindings.
The binding change looks correct, but using
devm_regulator_get_optional() does not sound correct.

devm_regulator_get_optional() is to be used when the device in question
truly can function without the power supply. But if the supply is there,
it's just not controlled by the SW, devm_regulator_get() is to be used.

At least this is my understanding.

 Tomi

Attachments

Thread (8 messages) 8 messages, 4 authors, last reply 2016-11-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help