Re: [PATCH 3/3] mdacon: replace MDA_ADDR macro by inline function

On 07/25/2016, 06:04 PM, Joe Perches wrote:

On Mon, 2016-07-25 at 17:24 +0200, Jiri Slaby wrote:

quoted

MDA_ADDR is one of those macros which could be an inline function. So
convert MDA_ADDR to mda_addr.

Signed-off-by: Jiri Slaby <redacted>
---
 drivers/video/console/mdacon.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/drivers/video/console/mdacon.c b/drivers/video/console/mdacon.c
index 814606bd26d1..24fe55134eb5 100644
--- a/drivers/video/console/mdacon.c
+++ b/drivers/video/console/mdacon.c

@@ -420,17 +420,20 @@ static void mdacon_invert_region(struct vc_data *c, u16 *p, int count)
 	}
 }
 
-#define MDA_ADDR(x, y)  (mda_vram_base + (y)*mda_num_columns + (x))
+static inline u16 *mda_addr(unsigned int x, unsigned int y)

Are you sure about the unsigned?
All of the changed use are taking int

Yeah, they are really absolute x and y coordinates.

thanks,
-- 
js
suse labs