Re: [PATCH 5/5] fbmon: remove unused function argument
From: Tomi Valkeinen <hidden>
Date: 2016-06-16 12:58:06
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 819 bytes
From: Tomi Valkeinen <hidden>
Date: 2016-06-16 12:58:06
Also in:
lkml
On 16/06/16 14:38, Arnd Bergmann wrote:
When building with "make W=1", we get a warning about an empty stub function that does nothing but reassign its one of its arguments: drivers/video/fbdev/core/fbmon.c: In function 'fb_edid_to_monspecs': drivers/video/fbdev/core/fbmon.c:1497:67: error: parameter 'specs' set but not used [-Werror=unused-but-set-parameter] We can simply make that function completely empty to avoid the warning. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/video/fbdev/core/fbmon.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c index 55e39e822b79..eaa6bab21839 100644 --- a/drivers/video/fbdev/core/fbmon.c +++ b/drivers/video/fbdev/core/fbmon.c@@ -1496,7 +1496,6 @@ int fb_parse_edid(unsigned char *edid, struct fb_var_screeninfo *var) } void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs) { - specs = NULL; } void fb_edid_add_monspecs(unsigned char *edid, struct fb_monspecs *specs) {
Thanks, queued for 4.8. Tomi