Thread (30 messages) flat view 30 messages, 5 authors, 2016-04-17
STALE3807d

Revision v5 of 4 in this series.

Revisions (4)
  1. rfc [diff vs current]
  2. v4 [diff vs current]
  3. v5 [diff vs current]
  4. v5 current

[PATCH v5 13/24] input: misc: max8997: explicitly apply PWM config extracted from pwm_args

From: Boris Brezillon <hidden>
Date: 2016-04-14 19:18:50
Also in: intel-gfx, linux-arm-kernel, linux-clk, linux-input, linux-leds, linux-pwm, linux-rockchip, linux-samsung-soc, lkml
Subsystem: input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers: Dmitry Torokhov, Linus Torvalds

Call pwm_apply_args() just after requesting the PWM device so that the
polarity and period are initialized according to the information provided
in pwm_args.

This is an intermediate state, and pwm_apply_args() should be dropped as
soon as the atomic PWM infrastructure is in place and the driver makes
use of it.

Signed-off-by: Boris Brezillon <redacted>
---
 drivers/input/misc/max8997_haptic.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/drivers/input/misc/max8997_haptic.c b/drivers/input/misc/max8997_haptic.c
index a806ba3..bf17f65 100644
--- a/drivers/input/misc/max8997_haptic.c
+++ b/drivers/input/misc/max8997_haptic.c
@@ -304,6 +304,12 @@ static int max8997_haptic_probe(struct platform_device *pdev)
 				error);
 			goto err_free_mem;
 		}
+
+		/*
+		 * FIXME: pwm_apply_args() should be removed when switching to
+		 * the atomic PWM API.
+		 */
+		pwm_apply_args(chip->pwm);
 		break;
 
 	default:
-- 
2.5.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help