Re: [PATCH 3/7 v2] video: ARM CLCD: support DT signal inversion flags

From
Linus Walleij <hidden>
Date
2016-03-07 04:45:20
Also in
linux-arm-kernel
Reply to
Tomi Valkeinen, 2016-02-26
On Fri, Feb 26, 2016 at 5:34 PM, Tomi Valkeinen [off-list ref] wrote:
quoted
+     /* Set up some inversion flags */
+     timnp = of_get_child_by_name(node, "panel-timing");
+     if (timnp && of_property_read_bool(timnp, "pixelclk-active")) {
Hmm, why are you poking in the videomode DT properties directly?
It is to provide
backward compatibility with already deployed device trees that
do not have this property set, so that they default to negative edge
rather than positive edge.
If the
pixelclk-active was not defined in the DT, you should see it in the
videomode struct as neither DISPLAY_FLAGS_PIXDATA_POSEDGE nor
DISPLAY_FLAGS_PIXDATA_NEGEDGE being set (I think, I didn't go through
the code in detail).
OK I'll take a look!

Yours,
Linus Walleij
Thread (15 messages) 15 messages, 3 authors, last reply 2016-04-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help