Re: [PATCH v2 1/2] video: goldfishfb: add devicetree bindings

Started by Rob Herring on Mar 18, 2016

open the first message on its own page

Message details and related content
On Thu, Mar 10, 2016 at 03:39:00PM +0000, Alan wrote:
From: Greg Hackmann <redacted>

Add device tree bindings to the Goldfish frame buffer interface.

Signed-off-by: Greg Hackmann <redacted>
Signed-off-by: Jin Qian <redacted>
Signed-off-by: Alan Cox <redacted>
---
[...]
quoted hunk
diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
index 7f6c9e6..f0e651b 100644
--- a/drivers/video/fbdev/goldfishfb.c
+++ b/drivers/video/fbdev/goldfishfb.c
@@ -304,12 +304,19 @@ static int goldfish_fb_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id goldfish_fb_of_match[] = {
+	{ .compatible = "google,goldfish-fb", },
+	{},
+};
+MODULE_DEVICE_TABLE(of, goldfish_fb_of_match);
 
 static struct platform_driver goldfish_fb_driver = {
 	.probe		= goldfish_fb_probe,
 	.remove		= goldfish_fb_remove,
 	.driver = {
-		.name = "goldfish_fb"
+		.name = "goldfish_fb",
+		.owner = THIS_MODULE,
This can be dropped. Otherwise,

Acked-by: Rob Herring <robh@kernel.org>
+		.of_match_table = goldfish_fb_of_match,
 	}
 };
 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help