Re: [PATCH 1/5] Subject: video: goldfishfb: add devicetree bindings
From: Tomi Valkeinen <hidden>
Date: 2016-03-07 18:29:21
Also in:
linux-devicetree
On 26/02/16 20:41, Alan wrote:
From: Greg Hackmann <redacted> Add device tree bindings to the Goldfish frame buffer interface. Signed-off-by: Greg Hackmann <redacted> Signed-off-by: Jin Qian <redacted> Signed-off-by: Alan Cox <redacted> --- Documentation/devicetree/bindings/goldfish/fb.txt | 17 +++++++++++++++++ drivers/video/fbdev/goldfishfb.c | 9 ++++++++- 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/goldfish/fb.txt
Device tree bindings should also be sent to the devicetree mailing list.
quoted hunk
diff --git a/Documentation/devicetree/bindings/goldfish/fb.txt b/Documentation/devicetree/bindings/goldfish/fb.txt new file mode 100644 index 0000000..c7d2d46 --- /dev/null +++ b/Documentation/devicetree/bindings/goldfish/fb.txt@@ -0,0 +1,17 @@ +Android Goldfish Framebuffer + +Andorid goldfish framebuffer device generated by android emulator.
Typo there in Android.
quoted hunk
+ +Required properties: + +- compatible : should contain "google,goldfish-fb" to match emulator +- reg : <registers mapping> +- interrupts : <interrupt mapping> + +Example: + + goldfish_fb@9010000 { + compatible = "google,goldfish-fb"; + reg = <0x9010000 0x100>; + interrupts = <0x2>; + };diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c index 7f6c9e6..f0e651b 100644 --- a/drivers/video/fbdev/goldfishfb.c +++ b/drivers/video/fbdev/goldfishfb.c@@ -304,12 +304,19 @@ static int goldfish_fb_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id goldfish_fb_of_match[] = { + { .compatible = "google,goldfish-fb", }, + {}, +}; +MODULE_DEVICE_TABLE(of, goldfish_fb_of_match); static struct platform_driver goldfish_fb_driver = { .probe = goldfish_fb_probe, .remove = goldfish_fb_remove, .driver = { - .name = "goldfish_fb" + .name = "goldfish_fb", + .owner = THIS_MODULE, + .of_match_table = goldfish_fb_of_match, } };
Attachments
- signature.asc [application/pgp-signature] 819 bytes