Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select
From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-02-16 15:08:35
Also in:
linux-arm-kernel, lkml, xen-devel
On Tuesday 16 February 2016 12:14:14 Stefano Stabellini wrote:
quoted
at all.Please correct me if I am wrong, but the difference is that with this change if INPUT=m, then the build system would ask the user whether she wants to select INPUT_XEN_KBDDEV_FRONTEND as m or y, instead of unconditionally set INPUT_XEN_KBDDEV_FRONTEND=y.
INPUT_XEN_KBDDEV_FRONTEND cannot be set by the user to 'y' if INPUT=m, because of an implied dependency around the input/misc/Kconfig file.
quoted hunk ↗ jump to hunk
However it is true that if the users chooses INPUT_XEN_KBDDEV_FRONTEND=y, then the problem persists. Maybe we also need:diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig index 1f2337a..303df24 100644 --- a/drivers/input/misc/Kconfig +++ b/drivers/input/misc/Kconfig@@ -721,7 +721,7 @@ config INPUT_CMA3000_I2C config INPUT_XEN_KBDDEV_FRONTEND tristate "Xen virtual keyboard and mouse support" - depends on XEN + depends on XEN && INPUT default y select XEN_XENBUS_FRONTEND helpDo you have a kernel config with INPUT=m that I can use to test with?
You can easily set that in any config if you disable CONFIG_VT. I don't think it's worth spending more time on that, as everyone seems to be happy with just removing the 'select', and I've sent a replacement patch to do that. Arnd