Re: [RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko

From
Frans Klaver <hidden>
Date
2015-12-29 13:49:18
Also in
lkml
Reply to
Sebastian Frias, 2015-12-29
On Tue, Dec 29, 2015 at 2:15 PM, Sebastian Frias [off-list ref] wrote:
Hi,

We are wondering what is the recommended way of adding support for a
framebuffer driver on the Linux kernel.
Below you can find a patch with a proposed solution.
That's not really a solution to add a driver to the kernel. You'd have
to include some actual driver code as well.

Our frambuffer driver source code is provided separately, but right now it
requires "cfb_fillrect", "cfb_copyarea" and "cfb_imageblit" to be provided
by the kernel.

Our current kernel fork (based on 3.4) hardcodes FB_CFB_FILLRECT,
FB_CFB_COPYAREA and FB_CFB_IMAGEBLIT to yes.
Since we are in the process of migrating to 4.x and upstreaming changes
along the way, we would like to know if the patch below is the way to go
with it or if you have suggestions to improve it.
Is the below patch really a patch you intend to upstream, or are you
just wondering about what your Kconfig entry should look like when you
upstream your driver?

quoted hunk ↗ jump to hunk
Subject: [RFC PATCH] fbdev: add support for Sigma Designs' smp8xxxfb.ko

Signed-off-by: Sebastian Frias <redacted>
---
 drivers/video/fbdev/Kconfig |   10 ++++++++++
 1 file changed, 10 insertions(+)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index e6d16d6..46c4ab2 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -615,6 +615,16 @@ config FB_BF537_LQ035
          To compile this driver as a module, choose M here: the
          module will be called bf537-lq035.

+config FB_TANGO
+       bool "Sigma Designs FrameBuffer support"
+       depends on FB && ARCH_TANGO
+       select FB_CFB_FILLRECT
+       select FB_CFB_COPYAREA
+       select FB_CFB_IMAGEBLIT
+       help
+         You need to enable this if you intend to use Sigma
+         Designs' smp8xxxfb.ko driver.
+
 config FB_BFIN_7393
        tristate "Blackfin ADV7393 Video encoder"
        depends on FB && BLACKFIN
Frans
Thread (9 messages) 9 messages, 4 authors, last reply 2016-01-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help