Re: [PATCH v2] video: fbdev: fsl: fix kernel crash when diu_ops is not implemented
From: Timur Tabi <hidden>
Date: 2015-12-03 01:12:49
Dongsheng Wang wrote:
From: Wang Dongsheng <redacted> If diu_ops is not implemented on platform, kernel will access a null pointer. we need to check this pointer in diu initialization.
Please fix capitalization: We, DIU, NULL.
quoted hunk ↗ jump to hunk
@@ -1915,6 +1918,10 @@ static int __init fsl_diu_init(void) #else monitor_port = fsl_diu_name_to_port(monitor_string); #endif + + if (!diu_ops.set_pixel_clock) + return -ENODEV; +
Please add a comment explaining that set_pixel_clock is required, so if it isn't set, then that means that there is no platform support for the DIU.