[PATCH 1/2] staging: sm750fb: move opening brace to previous line
Subsystems:
staging - silicon motion sm750 frame buffer driver , staging subsystem , the rest
STALE3948d
5 messages,
2 authors,
2015-11-08 · open the first message on its own page
Fixes the checkpatch.pl error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Othmar Pasteka <redacted>
---
drivers/staging/sm750fb/sm750_cursor.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index 3b7ce92..cab891c 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -143,8 +143,7 @@ void hw_cursor_setData(struct lynx_cursor *cursor,
iowrite16 ( data , pbuffer );
/* assume pitch is 1,2,4,8,...*/
- if (( i + 1 ) % pitch = 0 )
- {
+ if (( i + 1 ) % pitch = 0 ) {
/* need a return */
pstart += offset ;
pbuffer = pstart ; --
2.5.3
checkpatch.pl says: CHECK: spaces preferred around that '+' (ctx:VxV)
Signed-off-by: Othmar Pasteka <redacted>
---
drivers/staging/sm750fb/sm750_cursor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index cab891c..0a41585 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -143,7 +143,7 @@ void hw_cursor_setData(struct lynx_cursor *cursor,
iowrite16 ( data , pbuffer );
/* assume pitch is 1,2,4,8,...*/
- if (( i + 1 ) % pitch = 0 ) {
+ if (( i + 1 ) % pitch = 0 ) {
/* need a return */
pstart += offset ;
pbuffer = pstart ; --
2.5.3
If it's a one line fix then just send it as a single patch.
regards,
dan carpenter
On Sun, Nov 08, 2015 at 09:35:08AM +0300, Dan Carpenter wrote: If it's a one line fix then just send it as a single patch.
It was two things, hence I made it a two-parter.
Should I send a new version or is it a note for next time?
Thanks,
Othmar Pasteka
On Sun, Nov 08, 2015 at 08:33:16AM +0100, Othmar Pasteka wrote: Should I send a new version or is it a note for next time?
Send a new version.
regards,
dan carpenter