Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding
flat view
From: Philipp Zabel <hidden>
Date: 2015-10-06 06:58:12
Also in:
linux-devicetree, lkml
On Sun, Oct 4, 2015 at 12:31 PM, Robert Jarzmik [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Add documentation for the PXA frambuffer devicetree binding. Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> --- Since v1: Philipp's review on the whole binding --- .../devicetree/bindings/video/marvell,pxafb.txt | 80 ++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/marvell,pxafb.txtdiff --git a/Documentation/devicetree/bindings/video/marvell,pxafb.txt b/Documentation/devicetree/bindings/video/marvell,pxafb.txt new file mode 100644 index 000000000000..4d6bd490680d --- /dev/null +++ b/Documentation/devicetree/bindings/video/marvell,pxafb.txt@@ -0,0 +1,80 @@ +PXA LCDC Framebuffer +-------------------- + +Required properties: + - compatible : + "marvell,pxa2xx-lcdc", + - reg : Should contain 1 register ranges(address and length). + Can contain an additional register range(address and length) + for fixed framebuffer memory. Useful for dedicated memories. + - interrupts : framebuffer controller interrupt + +Required nodes: + - clocks: phandle to input clocks. + - port: connection to the LCD panel (see video-interfaces.txt) + This nodes must have its properties bus-width and remote-endpoint set. + This should be in the board dts. + +Example: + + lcd-controller@40500000 { + compatible = "marvell,pxa2xx-lcdc"; + reg = <0x44000000 0x10000>; + interrupts = <17>; + clocks = <&clks CLK_LCD>; + interrupts = <23>;
The interrupt line is duplicated in the example.
quoted hunk ↗ jump to hunk
+ status = "okay"; + + port { + lcdc_out: endpoint { + remote-endpoint = <&panel_in>; + bus-width = <16>; + }; + }; + }; + +PXA LCDC Display +---------------- +Required properties (as per of_videomode_helper): + - lcd-type: either "mono-stn", "mono-dstn", "color-stn", "color-dstn", + "color-tft", "smart-panel"
Would it make sense to make this property optional and have the default be "color-tft"? That is probably the most common one by far. regards Philipp