Re: [PATCH 1/7] cpufreq: remove redundant CPUFREQ_INCOMPATIBLE notifier event

From
Rafael J. Wysocki <rafael@kernel.org>
Date
2015-09-10 00:53:24
Also in
linux-acpi, linux-pm, lkml
Reply to
Viresh Kumar, 2015-09-10
Hi,

On Thu, Sep 10, 2015 at 2:39 AM, Viresh Kumar [off-list ref] wrote:
On 10-09-15, 01:26, Rafael J. Wysocki wrote:
quoted
On Monday, August 03, 2015 08:36:14 AM Viresh Kumar wrote:
quoted
What's being done from CPUFREQ_INCOMPATIBLE, can also be done with
CPUFREQ_ADJUST. There is nothing special with CPUFREQ_INCOMPATIBLE
notifier.
The above part of the changelog is a disaster to me. :-(

It not only doesn't explain what really goes on, but it's actively confusing.

What really happens is that the core sends CPUFREQ_INCOMPATIBLE notifications
unconditionally right after sending the CPUFREQ_ADJUST ones, so the former is
just redundant and it's more efficient to merge the two into one.
Undoubtedly this looks far better :)

But, isn't this series already applied some time back ?
Right, never mind.  For some reason that patch was left in the "New" state.

The code is OK.

Thanks,
Rafael
Thread (4 messages) 4 messages, 3 authors, last reply 2015-09-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help