[PATCH v2] fbdev: omap2: connector-dvi: use of_get_i2c_adapter_by_node interface

Subsystems: framebuffer layer, omap display subsystem and framebuffer support (dss2), the rest

STALE3979d

2 messages, 2 authors, 2015-09-24 · open the first message on its own page

[PATCH v2] fbdev: omap2: connector-dvi: use of_get_i2c_adapter_by_node interface

From: Vladimir Zapolskiy <hidden>
Date: 2015-09-15 13:12:33

This change is needed to properly lock I2C bus driver, which serves DDC.

Prior to this change i2c_put_adapter() is misused, which may lead to
an overflow over zero of I2C bus driver user counter.

Signed-off-by: Vladimir Zapolskiy <redacted>
---
Changes from v1 to v2:
- none, v1 is http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/354990.html

The original series http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/354982.html
is separated to i2c, dri and fbdev parts, at the moment i2c part
with new of_get_i2c_adapter_by_node() interface has been applied.

 drivers/video/fbdev/omap2/displays-new/connector-dvi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/displays-new/connector-dvi.c b/drivers/video/fbdev/omap2/displays-new/connector-dvi.c
index a8ce920..d811e6d 100644
--- a/drivers/video/fbdev/omap2/displays-new/connector-dvi.c
+++ b/drivers/video/fbdev/omap2/displays-new/connector-dvi.c
@@ -294,7 +294,7 @@ static int dvic_probe_of(struct platform_device *pdev)
 
 	adapter_node = of_parse_phandle(node, "ddc-i2c-bus", 0);
 	if (adapter_node) {
-		adapter = of_find_i2c_adapter_by_node(adapter_node);
+		adapter = of_get_i2c_adapter_by_node(adapter_node);
 		if (adapter = NULL) {
 			dev_err(&pdev->dev, "failed to parse ddc-i2c-bus\n");
 			omap_dss_put_device(ddata->in);
-- 
2.5.0

Re: [PATCH v2] fbdev: omap2: connector-dvi: use of_get_i2c_adapter_by_node interface

From: Tomi Valkeinen <hidden>
Date: 2015-09-24 11:31:52

On 15/09/15 16:12, Vladimir Zapolskiy wrote:
quoted hunk
This change is needed to properly lock I2C bus driver, which serves DDC.

Prior to this change i2c_put_adapter() is misused, which may lead to
an overflow over zero of I2C bus driver user counter.

Signed-off-by: Vladimir Zapolskiy <redacted>
---
Changes from v1 to v2:
- none, v1 is http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/354990.html

The original series http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/354982.html
is separated to i2c, dri and fbdev parts, at the moment i2c part
with new of_get_i2c_adapter_by_node() interface has been applied.

 drivers/video/fbdev/omap2/displays-new/connector-dvi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/displays-new/connector-dvi.c b/drivers/video/fbdev/omap2/displays-new/connector-dvi.c
index a8ce920..d811e6d 100644
--- a/drivers/video/fbdev/omap2/displays-new/connector-dvi.c
+++ b/drivers/video/fbdev/omap2/displays-new/connector-dvi.c
@@ -294,7 +294,7 @@ static int dvic_probe_of(struct platform_device *pdev)
 
 	adapter_node = of_parse_phandle(node, "ddc-i2c-bus", 0);
 	if (adapter_node) {
-		adapter = of_find_i2c_adapter_by_node(adapter_node);
+		adapter = of_get_i2c_adapter_by_node(adapter_node);
 		if (adapter == NULL) {
 			dev_err(&pdev->dev, "failed to parse ddc-i2c-bus\n");
 			omap_dss_put_device(ddata->in);
Thanks, queued for 4.3 fixes.

 Tomi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help