Re: [PATCH v2 09/11] fbdev: Allow compile test of GPIO consumers if !GPIOLIB

From
Tomi Valkeinen <hidden>
Date
2015-08-11 07:22:54
Also in
linux-gpio
Reply to
Geert Uytterhoeven, 2015-08-02

On 02/08/15 12:09, Geert Uytterhoeven wrote:
quoted hunk ↗ jump to hunk
The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
functionality only, can still be compiled if GPIOLIB is not enabled.

Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where
appropriate.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Linus Walleij <redacted>
---
v2:
  - Add Acked-by.
---
 drivers/video/fbdev/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 2d98de535e0f7374..569803f533d1a600 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -2464,7 +2464,7 @@ config FB_SSD1307
 	tristate "Solomon SSD1307 framebuffer support"
 	depends on FB && I2C
 	depends on OF
-	depends on GPIOLIB
+	depends on GPIOLIB || COMPILE_TEST
 	select FB_SYS_FOPS
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
Applied to 4.3 fbdev.

I do wonder why this is needed, though... I understand COMPILE_TEST if
the dependency in question is difficult/impossible to enable with your
kernel config (say, enabling OMAP SoC support with x86 config), but
isn't GPIOLIB something that can be trivially enabled in any kernel config?

 Tomi

Attachments

Thread (3 messages) 3 messages, 2 authors, last reply 2015-08-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help