Thread (4 messages) flat view 4 messages, 4 authors, 2015-08-26

Re: [PATCH] ARC: add negative dependency for VGA_CONSOLE

From: Vineet Gupta <hidden>
Date: 2015-08-25 07:47:55
Also in: linux-arch, lkml

On Monday 17 August 2015 09:51 PM, Geert Uytterhoeven wrote:
On Mon, Aug 17, 2015 at 5:52 PM, Yuriy Kolerov
[off-list ref] wrote:
quoted
Architectures which support VGA console must define screen_info
structurture from "uapi/linux/screen_info.h". Otherwise undefined
symbol error occurs. Usually it's defined in "setup.c" for each
architecture.

If an architecture does not support VGA console (ARC's case)
there are 2 ways: define a dummy instance of screen_info or add
a negative dependency for VGA_CONSOLE in to prevent selecting
this option.

I've implemented the second way. However the best solution is to
add HAVE_VGA_CONSOLE option for targets which support VGA
console. Then turn off VGA_CONSOLE by default and add dependency
to HAVE_VGA_CONSOLE. But right now it's better to just add a
negative dependency for ARC and then consider how to collaborate
about this issue with maintainers of other architectures.
+1
quoted
Signed-off-by: Yuriy Kolerov <redacted>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Hi Tomi,

Is anything else needed for this to be merged.

Thx,
-Vineet
Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help