On 08/05/2015 06:51 AM, Julien Grall wrote:

quoted

quoted

diff --git a/drivers/video/fbdev/xen-fbfront.c

b/drivers/video/fbdev/xen-fbfront.c
index 09dc447..25e3cce 100644

--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c

@@ -539,7 +539,7 @@ static int xenfb_remove(struct xenbus_device *dev)
     static unsigned long vmalloc_to_mfn(void *address)
   {
-    return pfn_to_mfn(vmalloc_to_pfn(address));
+    return pfn_to_gfn(vmalloc_to_pfn(address));
   }

Are you sure? This will return vmalloc_to_pfn(address)).

I guess you mean vmalloc_to_mfn will return vmalloc_to_pfn?

If so, it will be only the case on auto-translated case (because pfn =
gfn). In the case of PV, the mfn will be returned.

How will mfn be returned on PV when pfn_to_gfn() is an identity function?

static inline unsigned long pfn_to_gfn(unsigned long pfn)
  {
      return pfn;
  }


-boris

Although, this function is misnamed. It's fixed in a follow-up patch
(see #6) because it's required more renaming than this function. I
didn't want to add such changes within this patch.

Regards,