Re: [PATCH] fbcon: unconditionally initialize cursor blink interval
From: Pavel Machek <hidden>
Date: 2015-08-04 20:32:54
Also in:
lkml
On Tue 2015-08-04 12:33:32, Scot Doyle wrote:
A sun7i-a20-olinuxino-micro fails to boot when kernel parameter vt.global_cursor_default=0. The value is copied to vc->vc_deccm causing the initialization of ops->cur_blink_jiffies to be skipped. Unconditionally initialize it. Reported-and-tested-by: Jonathan Liu <redacted> Signed-off-by: Scot Doyle <redacted>
Acked-by: Pavel Machek <redacted>
quoted hunk ↗ jump to hunk
index 658c34b..1aaf893 100644--- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c@@ -1306,10 +1306,11 @@ static void fbcon_cursor(struct vc_data *vc, int mode) int y; int c = scr_readw((u16 *) vc->vc_pos); + ops->cur_blink_jiffies = msecs_to_jiffies(vc->vc_cur_blink_ms); + if (fbcon_is_inactive(vc, info) || vc->vc_deccm != 1) return; - ops->cur_blink_jiffies = msecs_to_jiffies(vc->vc_cur_blink_ms); if (vc->vc_cursor_type & 0x10) fbcon_del_cursor_timer(info); else
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html