OMAPDSS: dss-of: Fix node refcount leak in omapdss_of_get_next_port()

Started by Jyri Sarha on Aug 6, 2015 · 2 messages from 2 authors · Last reply Aug 7, 2015

Subsystems (3)

Maintainers (2)

STALE4115d

open the first message on its own page

Jyri Sarha

Message details and related content
Open message details and related content
Signed-off-by: Jyri Sarha <redacted>
---
 drivers/video/fbdev/omap2/dss/dss-of.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/fbdev/omap2/dss/dss-of.c b/drivers/video/fbdev/omap2/dss/dss-of.c
index 928ee63..ab6ef16 100644
--- a/drivers/video/fbdev/omap2/dss/dss-of.c
+++ b/drivers/video/fbdev/omap2/dss/dss-of.c
@@ -60,6 +60,7 @@ omapdss_of_get_next_port(const struct device_node *parent,
 			}
 			prev = port;
 		} while (of_node_cmp(port->name, "port") != 0);
+		of_node_put(ports);
 	}
 
 	return port;
-- 
1.9.1

Tomi Valkeinen replied to Jyri Sarha

Message details and related content
Open message details and related content

On 06/08/15 21:41, Jyri Sarha wrote:
Signed-off-by: Jyri Sarha <redacted>
Please always fill in the patch description. In simplest cases it may be
the same as in the subject.
quoted hunk
---
 drivers/video/fbdev/omap2/dss/dss-of.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/fbdev/omap2/dss/dss-of.c b/drivers/video/fbdev/omap2/dss/dss-of.c
index 928ee63..ab6ef16 100644
--- a/drivers/video/fbdev/omap2/dss/dss-of.c
+++ b/drivers/video/fbdev/omap2/dss/dss-of.c
@@ -60,6 +60,7 @@ omapdss_of_get_next_port(const struct device_node *parent,
 			}
 			prev = port;
 		} while (of_node_cmp(port->name, "port") != 0);
+		of_node_put(ports);
I think a blank line is needed above of_node_put().

 Tomi
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help