Re: [PATCH] backlight: pm8941-wled: Add default-brightness property
From: Lee Jones <hidden>
Date: 2015-07-24 08:22:32
Also in:
linux-arm-msm, linux-devicetree, lkml
On Thu, 23 Jul 2015, Bjorn Andersson wrote:
Add the possibility of specifying the default brightness in DT. Signed-off-by: Bjorn Andersson <redacted> --- This depends on the patch moving pm8941-wled to backlight [1]. The dt property is used by several other backlight drivers, so I considered this to be a "common" property and it's hence not prefixed with "qcom,". [1] https://lkml.org/lkml/2015/7/21/906 Documentation/devicetree/bindings/video/backlight/pm8941-wled.txt | 1 +
This needs to be in a seperate patch.
drivers/video/backlight/pm8941-wled.c | 4 ++++
You can't send patches on top of non-existent drivers.
quoted hunk ↗ jump to hunk
2 files changed, 5 insertions(+)diff --git a/Documentation/devicetree/bindings/video/backlight/pm8941-wled.txt b/Documentation/devicetree/bindings/video/backlight/pm8941-wled.txt index 424f8444a6cd..37503f8c3620 100644 --- a/Documentation/devicetree/bindings/video/backlight/pm8941-wled.txt +++ b/Documentation/devicetree/bindings/video/backlight/pm8941-wled.txt@@ -5,6 +5,7 @@ Required properties: - reg: slave address Optional properties: +- default-brightness: value from: 0-4095 - label: The name of the backlight device - qcom,cs-out: bool; enable current sink output - qcom,cabc: bool; enable content adaptive backlight controldiff --git a/drivers/video/backlight/pm8941-wled.c b/drivers/video/backlight/pm8941-wled.c index c704c3236034..b875e58df0fc 100644 --- a/drivers/video/backlight/pm8941-wled.c +++ b/drivers/video/backlight/pm8941-wled.c@@ -373,6 +373,7 @@ static int pm8941_wled_probe(struct platform_device *pdev) struct backlight_device *bl; struct pm8941_wled *wled; struct regmap *regmap; + u32 val = 0; int rc; regmap = dev_get_regmap(pdev->dev.parent, NULL);@@ -395,8 +396,11 @@ static int pm8941_wled_probe(struct platform_device *pdev) if (rc) return rc; + of_property_read_u32(pdev->dev.of_node, "default-brightness", &val); + memset(&props, 0, sizeof(struct backlight_properties)); props.type = BACKLIGHT_RAW; + props.brightness = val; props.max_brightness = PM8941_WLED_REG_VAL_MAX; bl = devm_backlight_device_register(&pdev->dev, wled->name, &pdev->dev, wled,
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog