On Tue, Jul 14, 2015 at 08:05:08PM -0700, Greg Kroah-Hartman wrote:

On Tue, Jul 07, 2015 at 01:44:36PM +0530, Sudip Mukherjee wrote:

quoted

+#define mmio_addr		0x00c00000
+#define seqw17

Odd, empty macros are not good, because:

quoted

-#ifdef __BIG_ENDIAN
 		if (sfb->fb->var.bits_per_pixel = 32)
-			smtc_seqw(0x17, 0x30);
-#endif
+			seqw17;

That just looks wrong :(

I think it will look better in c file if I make it as
#define seqw17()
I will respin the patches and send.

regards
sudip