RESEND

video: fbdev: s3c-fb: Constify platform_device_id

Started by Krzysztof Kozlowski on Jul 7, 2015 · 6 messages from 4 authors · Last reply Aug 21, 2015

Subsystems (3)

Maintainers (3)

STALE4098d

open the first message on its own page

Krzysztof Kozlowski Jul 7, 13:01 #

Message details and related content

Open message details and related content

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/fbdev/s3c-fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index 7e3a05fc47aa..f72dd12456f9 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c

@@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = {
 	},
 };
 
-static struct platform_device_id s3c_fb_driver_ids[] = {
+static const struct platform_device_id s3c_fb_driver_ids[] = {
 	{
 		.name		= "s3c-fb",
 		.driver_data	= (unsigned long)&s3c_fb_data_64xx,

-- 
2.1.4

Jingoo Han replied to Krzysztof Kozlowski Jul 8, 04:34 #

Message details and related content

Open message details and related content

On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski [off-list ref] wrote:

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

quoted hunk

---
drivers/video/fbdev/s3c-fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index 7e3a05fc47aa..f72dd12456f9 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c

@@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = {
   },

};

-static struct platform_device_id s3c_fb_driver_ids[] = {
+static const struct platform_device_id s3c_fb_driver_ids[] = {
   {
       .name        = "s3c-fb",
       .driver_data    = (unsigned long)&s3c_fb_data_64xx,
-- 
2.1.4

Krzysztof Kozlowski replied to Jingoo Han Jul 24, 06:12 #

Message details and related content

Open message details and related content

2015-07-08 13:34 GMT+09:00 Jingoo Han [off-list ref]:

On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski [off-list ref] wrote:

quoted

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

Seems nobody is picking it up, so I merge it through Samsung-SoC tree.
If there are any objections please let me know.

Best regards,
Krzysztof

quoted

---
drivers/video/fbdev/s3c-fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index 7e3a05fc47aa..f72dd12456f9 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c

@@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = {
   },

};

-static struct platform_device_id s3c_fb_driver_ids[] = {
+static const struct platform_device_id s3c_fb_driver_ids[] = {
   {
       .name        = "s3c-fb",
       .driver_data    = (unsigned long)&s3c_fb_data_64xx,
--
2.1.4

Tomi Valkeinen replied to Krzysztof Kozlowski Aug 20, 09:16 #

Message details and related content

Open message details and related content


On 24/07/15 09:12, Krzysztof Kozlowski wrote:

2015-07-08 13:34 GMT+09:00 Jingoo Han [off-list ref]:

quoted

On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski [off-list ref] wrote:

quoted

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

Seems nobody is picking it up, so I merge it through Samsung-SoC tree.
If there are any objections please let me know.

I can pick this up if you didn't already do that.

 Tomi

Krzysztof Kozlowski replied to Tomi Valkeinen Aug 21, 01:46 #

Message details and related content

Open message details and related content

On 20.08.2015 18:16, Tomi Valkeinen wrote:


On 24/07/15 09:12, Krzysztof Kozlowski wrote:

quoted

2015-07-08 13:34 GMT+09:00 Jingoo Han [off-list ref]:

quoted

On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski [off-list ref] wrote:

quoted

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

Seems nobody is picking it up, so I merge it through Samsung-SoC tree.
If there are any objections please let me know.

I can pick this up if you didn't already do that.

Could you? It would be great.
Kukjin did not pick it up so it is still waiting for some attention. :)

Best regards,
Krzysztof

Tomi Valkeinen replied to Krzysztof Kozlowski Aug 21, 05:57 #

Message details and related content

Open message details and related content


On 21/08/15 04:46, Krzysztof Kozlowski wrote:

On 20.08.2015 18:16, Tomi Valkeinen wrote:

quoted


On 24/07/15 09:12, Krzysztof Kozlowski wrote:

quoted

2015-07-08 13:34 GMT+09:00 Jingoo Han [off-list ref]:

quoted

On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski [off-list ref] wrote:

quoted

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

Seems nobody is picking it up, so I merge it through Samsung-SoC tree.
If there are any objections please let me know.

I can pick this up if you didn't already do that.

Could you? It would be great.
Kukjin did not pick it up so it is still waiting for some attention. :)

Ok. I've queued this for 4.3.

 Tomi

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help