Re: [PATCH v5 1/3] video: fbdev: atyfb: clarify ioremap() base and length used
From: Ville Syrjälä <syrjala@sci.fi>
Date: 2015-06-25 23:04:56
Also in:
linux-pci, lkml
On Wed, Jun 24, 2015 at 06:34:18PM -0700, Luis R. Rodriguez wrote:
quoted hunk ↗ jump to hunk
From: "Luis R. Rodriguez" <redacted> This has no functional changes, it just adjusts the ioremap() call for the framebuffer to use the same values we later use for the framebuffer, this will make it easier to review the next change. The size of the framebuffer varies but since this is for PCI we *know* this defaults to 0x800000. atyfb_setup_generic() is *only* used on PCI probe. Cc: Toshi Kani <redacted> Cc: Suresh Siddha <redacted> Cc: Ingo Molnar <redacted> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Thomas Gleixner <redacted> Cc: Juergen Gross <jgross@suse.com> Cc: Daniel Vetter <redacted> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Dave Airlie <airlied@redhat.com> Cc: Antonino Daplas <adaplas@gmail.com> Cc: Jean-Christophe Plagniol-Villard <redacted> Cc: Tomi Valkeinen <redacted> Cc: Ville Syrjälä <syrjala@sci.fi> Cc: Rob Clark <redacted> Cc: Mathias Krause <redacted> Cc: Andrzej Hajda <redacted> Cc: Mel Gorman <mgorman@suse.de> Cc: Vlastimil Babka <redacted> Cc: Borislav Petkov <redacted> Cc: Davidlohr Bueso <redacted> Cc: linux-fbdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Luis R. Rodriguez <redacted> --- drivers/video/fbdev/aty/atyfb_base.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index 16936bb..8025624 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c@@ -3489,7 +3489,9 @@ static int atyfb_setup_generic(struct pci_dev *pdev, struct fb_info *info, /* Map in frame buffer */ info->fix.smem_start = addr; - info->screen_base = ioremap(addr, 0x800000); + info->fix.smem_len = 0x800000; + + info->screen_base = ioremap(info->fix.smem_start, info->fix.smem_len);
The framebuffer size isn't always 8MB. That's the size of the BAR. So this change isn't really correct. I suppose it doesn't hurt too much since smem_len gets overwritten later in aty_init().
if (info->screen_base = NULL) {
ret = -ENOMEM;
goto atyfb_setup_generic_fail;
--
2.3.2.209.gd67f9d5.dirty-- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/