Thread (5 messages) 5 messages, 2 authors, 2015-06-24

Re: [PATCH] staging: sm750fb: use tabs for indentation

From: Dan Carpenter <hidden>
Date: 2015-06-24 09:29:04
Also in: lkml

On Mon, Jun 22, 2015 at 11:30:30AM -0700, Juston Li wrote:
On Mon, Jun 22, 2015 at 10:46 AM, Dan Carpenter
[off-list ref] wrote:
quoted
On Fri, Jun 19, 2015 at 05:50:50PM -0700, Juston Li wrote:
quoted
 void sii164ClearInterrupt(void)
 {
-    unsigned char detectReg;
+     unsigned char detectReg;

-    /* Clear the MDI interrupt */
-    detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT);
-    i2cWriteReg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg | SII164_DETECT_MONITOR_STATE_CLEAR);
The patch accidentally deletes this write.
quoted
+     /* Clear the MDI interrupt */
+     detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT);
 }
regards,
dan carpenter
This was fixed and patch is now included in the patchset:
[PATCH v2 00/19] staging: sm750fb: checkpatch.pl fixes
Have you sent this patchset to the list?  I don't see it in my inbox.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help