On Sat, Jun 20, 2015 at 12:43 AM, Sudip Mukherjee
[off-list ref] wrote:

On Fri, Jun 19, 2015 at 10:50:57PM -0700, Juston Li wrote:

quoted

Replace spaces with tabs for indentation to fix the checkpatch.pl warning
'WARNING: please, no spaces at the start of a line'

checkpatch doesn't catch comments indented by spaces but I fixed comments
adjacent to warnings as well so they would remain aligned.

Signed-off-by: Juston Li <redacted>
---

<snip>

quoted

diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c
index 7826376..23d6e19 100644
--- a/drivers/staging/sm750fb/ddk750_hwi2c.c
+++ b/drivers/staging/sm750fb/ddk750_hwi2c.c

@@ -9,71 +9,69 @@
 #define HWI2C_WAIT_TIMEOUT              0xF0000


-int hwI2CInit(
-    unsigned char busSpeedMode
-)
+int hwI2CInit(unsigned char busSpeedMode)

but this is what you say in commit message. Please only do one type of
change in a single patch.

Yeah, there were a couple of those changes I forgot to mention.
They were cases where there was nothing to align the lines to and it was
easier just to fix the overall code style.

It is a separate change so I'll remove the changes and resend.
I actually finished on several other  checkpatch.pl fix patches so
I'll just include this in a patchset.

Regards
Juston
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in