Thread (2 messages) 2 messages, 2 authors, 2015-05-19

Re: [PATCH v3 01/17] mfd: add new driver for Sharp LoCoMo

From: Russell King - ARM Linux <hidden>
Date: 2015-05-19 11:21:34
Also in: alsa-devel, linux-arm-kernel, linux-gpio, linux-input, linux-leds, linux-spi

On Tue, May 19, 2015 at 11:38:28AM +0100, Lee Jones wrote:
On Sun, 17 May 2015, Dmitry Eremin-Solenikov wrote:
quoted
+static void locomo_mask_irq(struct irq_data *d)
+{
+	struct locomo *ldev = irq_data_get_irq_chip_data(d);
+	unsigned int mask = 0x0010 << d->hwirq;
This also needs defining.

Why not
  BIT(d->hwirq + 1)
I think your maths is off...

0x0010 << d->hwirq != BIT(d->hwirq + 1)

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help