[PATCH 1/1 linux-next] video: fbdev: use swap() in ami_set_sprite()

Subsystems: framebuffer layer, the rest

STALE4125d

2 messages, 2 authors, 2015-05-18 · open the first message on its own page

[PATCH 1/1 linux-next] video: fbdev: use swap() in ami_set_sprite()

From: Fabian Frederick <hidden>
Date: 2015-05-18 17:32:16

Use kernel.h macro definition.

Signed-off-by: Fabian Frederick <redacted>
---
 drivers/video/fbdev/amifb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/amifb.c b/drivers/video/fbdev/amifb.c
index 35f7900..a171bd9 100644
--- a/drivers/video/fbdev/amifb.c
+++ b/drivers/video/fbdev/amifb.c
@@ -2052,7 +2052,7 @@ static void ami_set_sprite(const struct amifb_par *par)
 {
 	copins *copl, *cops;
 	u_short hs, vs, ve;
-	u_long pl, ps, pt;
+	u_long pl, ps;
 	short mx, my;
 
 	cops = copdisplay.list[currentcop][0];
@@ -2078,7 +2078,7 @@ static void ami_set_sprite(const struct amifb_par *par)
 			if (mod2(vs)) {
 				lofsprite[1 << par->crsr.fmode] = spr2hw_ctl(vs, hs, ve);
 				shfsprite[1 << par->crsr.fmode] = spr2hw_ctl(vs + 1, hs, ve + 1);
-				pt = pl; pl = ps; ps = pt;
+				swap(pl, ps);
 			} else {
 				lofsprite[1 << par->crsr.fmode] = spr2hw_ctl(vs, hs, ve + 1);
 				shfsprite[1 << par->crsr.fmode] = spr2hw_ctl(vs + 1, hs, ve);
-- 
2.4.0

Re: [PATCH 1/1 linux-next] video: fbdev: use swap() in ami_set_sprite()

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2015-05-18 20:16:13

On Mon, May 18, 2015 at 7:32 PM, Fabian Frederick [off-list ref] wrote:
Use kernel.h macro definition.

Signed-off-by: Fabian Frederick <redacted>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help