[PATCH 1/4] video: backlight: da9052: Constify platform_device_id

Subsystems: backlight class/subsystem, dialog semiconductor drivers, framebuffer layer, the rest

STALE4108d

12 messages, 3 authors, 2015-06-03 · open the first message on its own page

[PATCH 1/4] video: backlight: da9052: Constify platform_device_id

From: Krzysztof Kozlowski <hidden>
Date: 2015-05-01 15:38:55 

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/backlight/da9052_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/da9052_bl.c b/drivers/video/backlight/da9052_bl.c
index b1943e7735a1..fd2be417aa64 100644
--- a/drivers/video/backlight/da9052_bl.c
+++ b/drivers/video/backlight/da9052_bl.c
@@ -152,7 +152,7 @@ static int da9052_backlight_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static struct platform_device_id da9052_wled_ids[] = {
+static const struct platform_device_id da9052_wled_ids[] = {
 	{
 		.name		= "da9052-wled1",
 		.driver_data	= DA9052_TYPE_WLED1,
-- 
2.1.4

[PATCH 2/4] video: fbdev: imxfb: Constify platform_device_id

From: Krzysztof Kozlowski <hidden>
Date: 2015-05-01 15:39:05 

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 84d1d29e532c..cee88603efc9 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -170,7 +170,7 @@ struct imxfb_info {
 	struct regulator	*lcd_pwr;
 };
 
-static struct platform_device_id imxfb_devtype[] = {
+static const struct platform_device_id imxfb_devtype[] = {
 	{
 		.name = "imx1-fb",
 		.driver_data = IMX1_FB,
-- 
2.1.4

[PATCH 3/4] video: fbdev: mxsfb: Constify platform_device_id

From: Krzysztof Kozlowski <hidden>
Date: 2015-05-01 15:39:08 

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/fbdev/mxsfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/mxsfb.c b/drivers/video/fbdev/mxsfb.c
index f8ac4a452f26..497971c82bb1 100644
--- a/drivers/video/fbdev/mxsfb.c
+++ b/drivers/video/fbdev/mxsfb.c
@@ -814,7 +814,7 @@ static void mxsfb_free_videomem(struct mxsfb_info *host)
 	free_pages_exact(fb_info->screen_base, fb_info->fix.smem_len);
 }
 
-static struct platform_device_id mxsfb_devtype[] = {
+static const struct platform_device_id mxsfb_devtype[] = {
 	{
 		.name = "imx23-fb",
 		.driver_data = MXSFB_V3,
-- 
2.1.4

[PATCH 4/4] video: fbdev: s3c-fb: Constify platform_device_id

From: Krzysztof Kozlowski <hidden>
Date: 2015-05-01 15:39:10 

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/fbdev/s3c-fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index 7e3a05fc47aa..f72dd12456f9 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = {
 	},
 };
 
-static struct platform_device_id s3c_fb_driver_ids[] = {
+static const struct platform_device_id s3c_fb_driver_ids[] = {
 	{
 		.name		= "s3c-fb",
 		.driver_data	= (unsigned long)&s3c_fb_data_64xx,
-- 
2.1.4

Re: [PATCH 1/4] video: backlight: da9052: Constify platform_device_id

From: Lee Jones <hidden>
Date: 2015-05-05 08:28:06 

On Sat, 02 May 2015, Krzysztof Kozlowski wrote:

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/backlight/da9052_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
quoted hunk
diff --git a/drivers/video/backlight/da9052_bl.c b/drivers/video/backlight/da9052_bl.c
index b1943e7735a1..fd2be417aa64 100644
--- a/drivers/video/backlight/da9052_bl.c
+++ b/drivers/video/backlight/da9052_bl.c
@@ -152,7 +152,7 @@ static int da9052_backlight_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static struct platform_device_id da9052_wled_ids[] = {
+static const struct platform_device_id da9052_wled_ids[] = {
 	{
 		.name		= "da9052-wled1",
 		.driver_data	= DA9052_TYPE_WLED1,
-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/4] video: fbdev: imxfb: Constify platform_device_id

From: Lee Jones <hidden>
Date: 2015-05-05 08:28:20 

On Sat, 02 May 2015, Krzysztof Kozlowski wrote:

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
quoted hunk
diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 84d1d29e532c..cee88603efc9 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -170,7 +170,7 @@ struct imxfb_info {
 	struct regulator	*lcd_pwr;
 };
 
-static struct platform_device_id imxfb_devtype[] = {
+static const struct platform_device_id imxfb_devtype[] = {
 	{
 		.name = "imx1-fb",
 		.driver_data = IMX1_FB,
-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 3/4] video: fbdev: mxsfb: Constify platform_device_id

From: Lee Jones <hidden>
Date: 2015-05-05 08:28:33 

On Sat, 02 May 2015, Krzysztof Kozlowski wrote:

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/fbdev/mxsfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
quoted hunk
diff --git a/drivers/video/fbdev/mxsfb.c b/drivers/video/fbdev/mxsfb.c
index f8ac4a452f26..497971c82bb1 100644
--- a/drivers/video/fbdev/mxsfb.c
+++ b/drivers/video/fbdev/mxsfb.c
@@ -814,7 +814,7 @@ static void mxsfb_free_videomem(struct mxsfb_info *host)
 	free_pages_exact(fb_info->screen_base, fb_info->fix.smem_len);
 }
 
-static struct platform_device_id mxsfb_devtype[] = {
+static const struct platform_device_id mxsfb_devtype[] = {
 	{
 		.name = "imx23-fb",
 		.driver_data = MXSFB_V3,
-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 4/4] video: fbdev: s3c-fb: Constify platform_device_id

From: Lee Jones <hidden>
Date: 2015-05-05 08:28:49 

On Sat, 02 May 2015, Krzysztof Kozlowski wrote:

The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/fbdev/s3c-fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
quoted hunk
diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index 7e3a05fc47aa..f72dd12456f9 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = {
 	},
 };
 
-static struct platform_device_id s3c_fb_driver_ids[] = {
+static const struct platform_device_id s3c_fb_driver_ids[] = {
 	{
 		.name		= "s3c-fb",
 		.driver_data	= (unsigned long)&s3c_fb_data_64xx,
-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/4] video: fbdev: imxfb: Constify platform_device_id

From: Tomi Valkeinen <hidden>
Date: 2015-06-03 11:39:35 

Hi Lee,

On 05/05/15 11:28, Lee Jones wrote:
On Sat, 02 May 2015, Krzysztof Kozlowski wrote:
quoted
The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
You applied the fbdev changes in this series also, not only the
backlight changes?

 Tomi

Re: [PATCH 2/4] video: fbdev: imxfb: Constify platform_device_id

From: Lee Jones <hidden>
Date: 2015-06-03 11:51:17 

On Wed, 03 Jun 2015, Tomi Valkeinen wrote:

Hi Lee,

On 05/05/15 11:28, Lee Jones wrote:
quoted
On Sat, 02 May 2015, Krzysztof Kozlowski wrote:
quoted
The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
You applied the fbdev changes in this series also, not only the
backlight changes?
Ah, yes I did.  I assumed they were all due for Backlight.

Would you like me to un-apply the non-Backlight patches?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/4] video: fbdev: imxfb: Constify platform_device_id

From: Tomi Valkeinen <hidden>
Date: 2015-06-03 11:54:25 


On 03/06/15 14:50, Lee Jones wrote:
On Wed, 03 Jun 2015, Tomi Valkeinen wrote:
quoted
Hi Lee,

On 05/05/15 11:28, Lee Jones wrote:
quoted
On Sat, 02 May 2015, Krzysztof Kozlowski wrote:
quoted
The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
You applied the fbdev changes in this series also, not only the
backlight changes?
Ah, yes I did.  I assumed they were all due for Backlight.

Would you like me to un-apply the non-Backlight patches?
If you can easily remove them, yes.

But chances for conflict are quite minimal, so if you already have a
pile of commits on top of these, it's fine if they go via backlight tree.

 Tomi

Re: [PATCH 2/4] video: fbdev: imxfb: Constify platform_device_id

From: Lee Jones <hidden>
Date: 2015-06-03 13:42:31 

On Wed, 03 Jun 2015, Tomi Valkeinen wrote:
On 03/06/15 14:50, Lee Jones wrote:
quoted
On Wed, 03 Jun 2015, Tomi Valkeinen wrote:
quoted
Hi Lee,

On 05/05/15 11:28, Lee Jones wrote:
quoted
On Sat, 02 May 2015, Krzysztof Kozlowski wrote:
quoted
The platform_device_id is not modified by the driver and core uses it as
const.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 drivers/video/fbdev/imxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
You applied the fbdev changes in this series also, not only the
backlight changes?
Ah, yes I did.  I assumed they were all due for Backlight.

Would you like me to un-apply the non-Backlight patches?
If you can easily remove them, yes.

But chances for conflict are quite minimal, so if you already have a
pile of commits on top of these, it's fine if they go via backlight tree.
I can easily remove them, no problem.

Consider them unapplied.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help