Re: [PATCH v4 1/2] IB/qib: add acounting for MTRR
From: Doug Ledford <hidden>
Date: 2015-04-22 13:45:54
Also in:
linux-rdma, lkml
On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote:
quoted hunk ↗ jump to hunk
From: "Luis R. Rodriguez" <redacted> There is no good reason not to, we eventually delete it as well. Cc: Toshi Kani <redacted> Cc: Suresh Siddha <redacted> Cc: Ingo Molnar <redacted> Cc: Thomas Gleixner <redacted> Cc: Juergen Gross <jgross@suse.com> Cc: Daniel Vetter <redacted> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Dave Airlie <airlied@redhat.com> Cc: Antonino Daplas <adaplas@gmail.com> Cc: Jean-Christophe Plagniol-Villard <redacted> Cc: Tomi Valkeinen <redacted> Cc: Mike Marciniszyn <redacted> Cc: Roland Dreier <roland@kernel.org> Cc: Sean Hefty <redacted> Cc: Hal Rosenstock <redacted> Cc: linux-rdma@vger.kernel.org Cc: linux-fbdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Luis R. Rodriguez <redacted> --- drivers/infiniband/hw/qib/qib_wc_x86_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/infiniband/hw/qib/qib_wc_x86_64.c b/drivers/infiniband/hw/qib/qib_wc_x86_64.c index 81b225f..fe0850a 100644 --- a/drivers/infiniband/hw/qib/qib_wc_x86_64.c +++ b/drivers/infiniband/hw/qib/qib_wc_x86_64.c@@ -118,7 +118,7 @@ int qib_enable_wc(struct qib_devdata *dd) if (!ret) { int cookie; - cookie = mtrr_add(pioaddr, piolen, MTRR_TYPE_WRCOMB, 0); + cookie = mtrr_add(pioaddr, piolen, MTRR_TYPE_WRCOMB, 1); if (cookie < 0) { { qib_devinfo(dd->pcidev,
Skip this patch please. You remove this line entirely in your next
patch, so this becomes a single kernel out of all possible bisectable
kernels with this accounting enabled, and then the very next kernel does
away with it. It makes no sense to have a single outlying bisectable
kernel like that.
--
Doug Ledford [off-list ref]
GPG KeyID: 0E572FDD
Attachments
- signature.asc [application/pgp-signature] 819 bytes