Re: [PATCH v1 05/47] pci: add pci_iomap_wc() variants

From
Michael S. Tsirkin <mst@redhat.com>
Date
2015-04-21 19:25:19
Also in
lkml, xen-devel
Reply to
Bjorn Helgaas, 2015-03-23
On Mon, Mar 23, 2015 at 12:20:47PM -0500, Bjorn Helgaas wrote:
pci_iomap_range() already makes a cacheable mapping if
IORESOURCE_CACHEABLE; I'm guessing that you would like it to
automatically use WC if the BAR if IORESOURCE_PREFETCH, e.g.,

  if (flags & IORESOURCE_CACHEABLE)
    return ioremap(start, len);
  if (flags & IORESOURCE_PREFETCH)
    return ioremap_wc(start, len);
  return ioremap_nocache(start, len);

Is there a reason not to do that?
I think that's wrong and will break a bunch of things.
PCI prefetch bit merely means bridges can combine writes and prefetch
reads.  Prefetch does not affect ordering rules and does not allow
writes to be collapsed.

WC is stronger: it allows collapsing and changes ordering rules.

WC can also hurt latency as small writes are buffered.

To summarise, driver needs to know what it's doing,
we can't set WC in the pci core automatically.

-- 
MST
Thread (110 messages) 110 messages, 10 authors, last reply 2015-04-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help