Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers
From: Liu Ying <hidden>
Date: 2015-04-03 03:39:32
Also in:
lkml, stable
From: Liu Ying <hidden>
Date: 2015-04-03 03:39:32
Also in:
lkml, stable
2015-03-20 19:26 GMT+08:00 Tomi Valkeinen [off-list ref]:
On 11/03/15 05:03, Liu Ying wrote:quoted
quoted
Why do you check for host->enabled here, but not elsewhere?We need this check here to make sure the axi clock reference count is no greater than 1. Looking at the context of mxsfb_set_par(), mxsfb_restore_mode() andWhy is that? The clock framework handles ref counting for you. All the driver needs to take care of is to call as many times disable as it calls enable.
Okay. I'll remove the check and send another version. Regards, Liu Ying
Tomi